server: fix exception in DeploymentPlanningManagerImplTest#6799
Merged
yadvr merged 1 commit intoapache:mainfrom Oct 4, 2022
Merged
Conversation
previously ``` [INFO] Running com.cloud.deploy.DeploymentPlanningManagerImplTest java.lang.NullPointerException at com.cloud.deploy.DeploymentPlanningManagerImpl.planDeployment(DeploymentPlanningManagerImpl.java:403) at com.cloud.deploy.DeploymentPlanningManagerImplTest.failEncRootLastHostNotSupportingEncryptionTest(DeploymentPlanningManagerImplTest.java:644) ... [INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.407 s - in com.cloud.deploy.DeploymentPlanningManagerImplTest ``` with this PR ``` [INFO] Running com.cloud.deploy.DeploymentPlanningManagerImplTest [INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.481 s - in com.cloud.deploy.DeploymentPlanningManagerImplTest [INFO] [INFO] Results: [INFO] [INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0 ```
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4344 |
yadvr
approved these changes
Oct 4, 2022
Member
|
I dont' see any unit test failures. |
weizhouapache
deleted the
4.18-fix-NPE-DeploymentPlanningManagerImplTest
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously
with this PR
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?